Fix path to derive accounts in HD wallets for RSK, ETC #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaranov
force-pushed
the
vb-fix-path-for-hd-walet
branch
from
a40c1a8
to
afd3b63
Compare
vbaranov
force-pushed
the
vb-fix-path-for-hd-walet
branch
from
afd3b63
to
6c3d143
Compare
…y-wallet into vb-fix-path-for-hd-walet
vbaranov
force-pushed
the
vb-fix-path-for-hd-walet
branch
4 times, most recently
from
44d30d4
to
1188ed4
Compare
vbaranov
force-pushed
the
vb-fix-path-for-hd-walet
branch
from
1188ed4
to
a672bf9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For RSK (testnet, mainnet) and Ethereum Classic chains, HD wallets accounts are derived from ETH path. This PR fixes paths for accounts derivation for mentioned chains.
https://forum.poa.network/t/hardware-wallets-are-not-working-with-rsk/3260