Simple SyncUp tutorial fixes #3141

dafurman · 2024-06-05T04:19:58Z

Breaking out simpler fixes from #3139. I'll readd the same comments I used there here, in case the extra context helps a bit.

dafurman · 2024-06-05T04:21:20Z

...Documentation.docc/Tutorials/BuildingSyncUps/05-PersistingSyncUps/PersistingSyncUps.tutorial

@@ -16,6 +16,8 @@
        Go back to the SyncUpsList.swift file, and start by applying the [`@Shared`](<doc:Shared>)
        property wrapper to the `syncUps` field.

+        > Note: Our changes will not compile until step 3.


Just a suggestion to throw this in, because often when I go through enough steps in a tutorial without code compiling, I end up wondering if I missed something in a step, which distracts from the tutorial itself.

However, if you don't want this change, you can revert 9d93448 where this is added

dafurman · 2024-06-05T04:22:49Z

...cumentation.docc/Tutorials/BuildingSyncUps/06-SyncUpDetail/EditingAndDeletingSyncUp.tutorial

@@ -184,7 +184,8 @@
      }

      @Step {
-        Use the ``ComposableArchitecture/Reducer/ifLet(_:action:then:fileID:line:)-42kki`` operator
+        Add support for the `.alert` case, and 


because the step also makes this change in the diff from
EditingAndDeletingSyncUp-02-code-0003.swift

swift-composable-architecture/Sources/ComposableArchitecture/Documentation.docc/Tutorials/BuildingSyncUps/06-SyncUpDetail/EditingAndDeletingSyncUp-02-code-0003.swift

Lines 28 to 29 in af38644

switch action {

case .cancelEditButtonTapped:

to
EditingAndDeletingSyncUp-02-code-0004.swift

swift-composable-architecture/Sources/ComposableArchitecture/Documentation.docc/Tutorials/BuildingSyncUps/06-SyncUpDetail/EditingAndDeletingSyncUp-02-code-0004.swift

Lines 28 to 32 in af38644

switch action {

case .alert:

return .none

case .cancelEditButtonTapped:

dafurman · 2024-06-05T04:24:15Z

...hitecture/Documentation.docc/Tutorials/BuildingSyncUps/06-SyncUpDetail/SyncUpDetail.tutorial

@@ -37,7 +37,7 @@
      }

      Next we add a case to the `Action` enum for each action the user can perform in the view.
-      Currently there are 3 buttons, and so we will have an action for each.
+      Currently there are 2 buttons, and so we will have an action for each.


From this, which today just covers the two actions - delete and edit.

swift-composable-architecture/Sources/ComposableArchitecture/Documentation.docc/Tutorials/BuildingSyncUps/06-SyncUpDetail/SyncUpDetail.tutorial

Lines 43 to 44 in af38644

Add an action for each of the buttons in the UI, including tapping the "Delete" button,

and the "Edit" button.

dafurman · 2024-06-05T04:26:55Z

...re/Documentation.docc/Tutorials/BuildingSyncUps/06-SyncUpDetail/TestingSyncUpDetail.tutorial

-        inside the `edit` case of the destination should change. We can use the special 
-        ``ComposableArchitecture/PresentationState/subscript(case:)-7uqte`` defined on
-        `$destination` to modify the data in a particular case.
+        inside the `edit` case of the destination should change.


This subscript syntax isn't being used here:

swift-composable-architecture/Sources/ComposableArchitecture/Documentation.docc/Tutorials/BuildingSyncUps/06-SyncUpDetail/TestingSyncUpDetail-01-code-0005.swift

Line 24 in af38644

$0.destination?.edit?.syncUp = editedSyncUp

dafurman · 2024-06-05T04:27:29Z

...occ/Tutorials/BuildingSyncUps/07-SyncUpDetailNavigation/MeetingNavigation-01-code-0003.swift

@@ -23,6 +23,31 @@ struct MeetingView: View {
  }
 }

+extension SyncUp {


Adding SyncUp.mock while we're making the MeetingView, which gets used later on in the tutorial

stephencelis

Thanks so much! Gonna apply a few suggestions below and merge 😄

...cumentation.docc/Tutorials/BuildingSyncUps/06-SyncUpDetail/EditingAndDeletingSyncUp.tutorial

...Documentation.docc/Tutorials/BuildingSyncUps/05-PersistingSyncUps/PersistingSyncUps.tutorial

...occ/Tutorials/BuildingSyncUps/07-SyncUpDetailNavigation/MeetingNavigation-01-code-0003.swift

…ildingSyncUps/06-SyncUpDetail/EditingAndDeletingSyncUp.tutorial

…ildingSyncUps/05-PersistingSyncUps/PersistingSyncUps.tutorial

…ildingSyncUps/07-SyncUpDetailNavigation/MeetingNavigation-01-code-0003.swift

…ure to from: "1.11.2" (#1137) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://github.com/pointfreeco/swift-composable-architecture) | minor | `from: "1.10.4"` -> `from: "1.11.2"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.11.2`](https://github.com/pointfreeco/swift-composable-architecture/releases/tag/1.11.2) [Compare Source](https://github.com/pointfreeco/swift-composable-architecture/compare/1.11.1...1.11.2) #### What's Changed - Fixed: Avoid potential sendability warnings in Swift 6 mode ([pointfreeco/swift-composable-architecture#3167). - Fixed: `PersistenceKeyDefault` no longer uses the loaded value as an initial value (thanks [@fdzsergio](https://github.com/fdzsergio), [pointfreeco/swift-composable-architecture#3174). - Fixed: Address a potential deadlock by isolating `Shared.withLock` to the main actor ([pointfreeco/swift-composable-architecture#3178). - Fixed: Disfavor `Shared`'s optional dynamic member lookup ([pointfreeco/swift-composable-architecture#3170). Note that this fix may be source breaking. See the [migration guide](https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.11) for more details. - Fixed: Don't over-observe app storage mutations ([pointfreeco/swift-composable-architecture#3186). - Fixed: `$shared.elements` is now stable based on identity, and restricted to identified arrays ([pointfreeco/swift-composable-architecture#3187). - Infrastructure: Drop Swift <5.9 support ([pointfreeco/swift-composable-architecture#3185). Xcode 15 has been required for app submission since April, so we can keep our Swift support in line with Apple's. - Infrastructure: 1.11 migration guide fixes (thanks [@larryonoff](https://github.com/larryonoff), [pointfreeco/swift-composable-architecture#3184); tutorial typo fixes (thanks [@meltsplit](https://github.com/meltsplit), [pointfreeco/swift-composable-architecture#3161). #### New Contributors - [@meltsplit](https://github.com/meltsplit) made their first contribution in [pointfreeco/swift-composable-architecture#3161 - [@fdzsergio](https://github.com/fdzsergio) made their first contribution in [pointfreeco/swift-composable-architecture#3174 **Full Changelog**: pointfreeco/swift-composable-architecture@1.11.1...1.11.2 ### [`v1.11.1`](https://github.com/pointfreeco/swift-composable-architecture/releases/tag/1.11.1) [Compare Source](https://github.com/pointfreeco/swift-composable-architecture/compare/1.11.0...1.11.1) #### What's Changed - Fixed: Support swift-syntax from 600.0.0-latest ([pointfreeco/swift-composable-architecture#3160). - Fixed: `Shared.withLock` now pass values by continuation ([pointfreeco/swift-composable-architecture#3154). - Infrastructure: Clean up DocC and link to new migration guide in README ([pointfreeco/swift-composable-architecture#3153); SyncUp tutorial fixes (thanks [@dafurman](https://github.com/dafurman), [pointfreeco/swift-composable-architecture#3139; thanks [@RuiAAPeres](https://github.com/RuiAAPeres), [pointfreeco/swift-composable-architecture#3159); note Swift bug in documentation ([pointfreeco/swift-composable-architecture#3157). #### New Contributors - [@RuiAAPeres](https://github.com/RuiAAPeres) made their first contribution in [pointfreeco/swift-composable-architecture#3159 **Full Changelog**: pointfreeco/swift-composable-architecture@1.11.0...1.11.1 ### [`v1.11.0`](https://github.com/pointfreeco/swift-composable-architecture/releases/tag/1.11.0) [Compare Source](https://github.com/pointfreeco/swift-composable-architecture/compare/1.10.4...1.11.0) #### What's Changed - Added: `Shared.withLock`, for mutating shared state from asynchronous contexts ([pointfreeco/swift-composable-architecture#3136). Direct mutations from asynchronous contexts is marked unavailable and will be an error in Swift 6. - Added: `SharedReader.constant` ([pointfreeco/swift-composable-architecture#3127). - Added: `$store.scope` will now emit a warning when a dismiss action doesn't `nil` out a child feature, suggesting a `Reducer.ifLet` (or parent integration) is missing ([pointfreeco/swift-composable-architecture#3089). - Deprecated: `Shared`'s optional dynamic member lookup overload has been deprecated in favor of a `Binding.init` that unwraps optional values ([pointfreeco/swift-composable-architecture#3145). - Fixed: Avoid crash when using `.appStorage` with a `URL` value (thanks [@pwszebor](https://github.com/pwszebor), [pointfreeco/swift-composable-architecture#3098). - Fixed: Worked around a build failure when integrating with Tuist ([pointfreeco/swift-composable-architecture#3140). - Infrastructure: Tutorial fixes ([pointfreeco/swift-composable-architecture#3076; thanks [@MartinMoizard](https://github.com/MartinMoizard), [pointfreeco/swift-composable-architecture#3078; [pointfreeco/swift-composable-architecture#3072; thanks [@hmhv](https://github.com/hmhv), [pointfreeco/swift-composable-architecture#3091; thanks [@gibachan](https://github.com/gibachan), [pointfreeco/swift-composable-architecture#3099; thanks [@btr-better](https://github.com/btr-better), [pointfreeco/swift-composable-architecture#3107; thanks [@woxtu](https://github.com/woxtu), [pointfreeco/swift-composable-architecture#3119, [pointfreeco/swift-composable-architecture#3123; [pointfreeco/swift-composable-architecture#3135; [pointfreeco/swift-composable-architecture#3141; [pointfreeco/swift-composable-architecture#3148); DocC fixes ([pointfreeco/swift-composable-architecture#3085; [pointfreeco/swift-composable-architecture#3087; thanks [@JOyo246](https://github.com/JOyo246), [pointfreeco/swift-composable-architecture#3092; thanks [@leeari95](https://github.com/leeari95), [pointfreeco/swift-composable-architecture#3110; [pointfreeco/swift-composable-architecture#3138); README fixes (thanks [@Matt54](https://github.com/Matt54), [pointfreeco/swift-composable-architecture#3129); expose some navigation APIs with `@_spi(Internal)` (thanks [@Alex293](https://github.com/Alex293), [pointfreeco/swift-composable-architecture#3097). #### New Contributors - [@MartinMoizard](https://github.com/MartinMoizard) made their first contribution in [pointfreeco/swift-composable-architecture#3078 - [@JOyo246](https://github.com/JOyo246) made their first contribution in [pointfreeco/swift-composable-architecture#3092 - [@pwszebor](https://github.com/pwszebor) made their first contribution in [pointfreeco/swift-composable-architecture#3098 - [@Alex293](https://github.com/Alex293) made their first contribution in [pointfreeco/swift-composable-architecture#3097 - [@gibachan](https://github.com/gibachan) made their first contribution in [pointfreeco/swift-composable-architecture#3099 - [@leeari95](https://github.com/leeari95) made their first contribution in [pointfreeco/swift-composable-architecture#3110 - [@btr-better](https://github.com/btr-better) made their first contribution in [pointfreeco/swift-composable-architecture#3107 - [@Matt54](https://github.com/Matt54) made their first contribution in [pointfreeco/swift-composable-architecture#3129 **Full Changelog**: pointfreeco/swift-composable-architecture@1.10.4...1.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

dafurman added 18 commits June 4, 2024 20:31

Typo, heirarchy -> hierarchy

8b43dd0

Typo: recursive -> recursively

81895df

Typo: comes -> combines

0e0deac

Typo: is -> to be

3384ee1

Typo: add -> we added

8756062

Typo: 3 -> 2

f6d67d9

Adding a note to avoid confusion

9d93448

Add more detail to step

ccac45b

Remove stray whitespace causing a diff to incorrectly display

142fbd0

Removed step documentation for unused code

061e90d

Typo: apart -> a part

b56f255

Typo: reducer -> reducers

58f5777

Add missing mock

8688606

Fix mainactor placement

1ab1b55

Fix transcript param not compiling

d8be214

Add durationPerAttendee to be usable

702e0b2

Undo a whitespace change

d37254d

Delete commented-out code

c3e67ea

dafurman changed the title ~~Simply SyncUp tutorial fixes~~ Simple SyncUp tutorial fixes Jun 5, 2024

dafurman commented Jun 5, 2024

View reviewed changes

Merge branch 'main' into simpleSyncUpTutorialFixes

357580f

dafurman marked this pull request as ready for review June 5, 2024 04:31

stephencelis approved these changes Jun 5, 2024

View reviewed changes

stephencelis added 3 commits June 5, 2024 09:37

Update Sources/ComposableArchitecture/Documentation.docc/Tutorials/Bu…

10e1410

…ildingSyncUps/06-SyncUpDetail/EditingAndDeletingSyncUp.tutorial

Update Sources/ComposableArchitecture/Documentation.docc/Tutorials/Bu…

4c504e8

…ildingSyncUps/05-PersistingSyncUps/PersistingSyncUps.tutorial

Update Sources/ComposableArchitecture/Documentation.docc/Tutorials/Bu…

43d2c71

…ildingSyncUps/07-SyncUpDetailNavigation/MeetingNavigation-01-code-0003.swift

stephencelis merged commit 63a0795 into pointfreeco:main Jun 5, 2024

dafurman deleted the simpleSyncUpTutorialFixes branch June 5, 2024 21:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simple SyncUp tutorial fixes #3141

Simple SyncUp tutorial fixes #3141

dafurman commented Jun 5, 2024

dafurman Jun 5, 2024 •

edited

Loading

dafurman Jun 5, 2024 •

edited

Loading

dafurman Jun 5, 2024 •

edited

Loading

dafurman Jun 5, 2024

dafurman Jun 5, 2024

stephencelis left a comment

	switch action {
	case .alert:
	return .none

	case .cancelEditButtonTapped:

	Add an action for each of the buttons in the UI, including tapping the "Delete" button,
	and the "Edit" button.

Simple SyncUp tutorial fixes #3141

Simple SyncUp tutorial fixes #3141

Conversation

dafurman commented Jun 5, 2024

dafurman Jun 5, 2024 • edited Loading

Choose a reason for hiding this comment

dafurman Jun 5, 2024 • edited Loading

Choose a reason for hiding this comment

dafurman Jun 5, 2024 • edited Loading

Choose a reason for hiding this comment

dafurman Jun 5, 2024

Choose a reason for hiding this comment

dafurman Jun 5, 2024

Choose a reason for hiding this comment

stephencelis left a comment

Choose a reason for hiding this comment

dafurman Jun 5, 2024 •

edited

Loading

dafurman Jun 5, 2024 •

edited

Loading

dafurman Jun 5, 2024 •

edited

Loading