Add final to UIViewControllers in UIKit CaseStudies
#3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junbangg
added a commit
to junbangg/swift-composable-architecture
that referenced
this pull request
Jul 14, 2024
…3221) * refactor: add final to EagerNavigationViewController * refactor: add final to LazyNavigationViewController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While checking out the UIKit CaseStudies, I noticed that a couple of ViewControllers were missing the
finalkeyword.I didn't see any subclassing, and all the other ViewControllers seem to have
final, so I assumed it was an oversight. Let me know if I'm missing something 👍