Enum reducers: generate direct action cases for ephemeral state #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the following reducer enum: ```swift @Reducer enum Destination { case alert(AlertState<Never>) } ``` Generates the following action: ```swift @CasePathable enum Action { case alert(AlertState<Never>.Action) } ``` And this produces a warning in Case Paths 1.5 due to the nested `Never` not being referenced directly. This PR plucks the action type out and embeds it directly, instead: ```diff -case alert(AlertState<Never>.Action) +case alert(Never) ``` Which will allow us to better suppress warnings Swift emits for uninhabited types.
mbrandonw
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following reducer enum:
Generates the following action:
And this produces a warning in Case Paths 1.5 due to the nested
Nevernot being referenced directly.This PR plucks the action type out and embeds it directly, instead:
Which will allow us to better suppress warnings Swift emits for uninhabited types.