Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Template] Zeroing GasLimitPovSizeRatio #1210

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Template] Zeroing GasLimitPovSizeRatio #1210

wants to merge 2 commits into from

Conversation

arturgontijo
Copy link
Contributor

I don't think we need PoV size weight for the frontier-template-node (solo chain).
It is adding gasUsed to all transactions.

@sorpaas
Copy link
Member

sorpaas commented Sep 27, 2023

Please fix the integration tests.

@arturgontijo
Copy link
Contributor Author

I decided to just remove that test case as we don't have PoV in the template node (also we use non-zero GasLimitPovSizeRatio some mock.rs files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koushiro koushiro koushiro approved these changes

@sorpaas sorpaas Awaiting requested review from sorpaas sorpaas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arturgontijo @sorpaas @koushiro