Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kusama: remove migrations applied by spec_version: 1_000_000 #73

Conversation

acatangiu
Copy link
Contributor

@acatangiu acatangiu commented Oct 23, 2023

Runtimes 1.0.0 has been released: https://github.com/polkadot-fellows/runtimes/releases/tag/v1.0.0 and Kusama has now successfully updated on-chain to spec: 1_000_000.

This PR removes migrations that have been applied by the successful update of the Kusama runtime to above version.

@acatangiu acatangiu changed the title Kusama remove migrations applied by spec_version: 1_000_000 Kusama: remove migrations applied by spec_version: 1_000_000 Oct 23, 2023
@acatangiu
Copy link
Contributor Author

The 1st commit is the mandatory one, it removes the SessionKeys migration which doesn't have protections in place to allow multiple runs of the migration.

The other ones' removal at this point is optional, but if we see them applied on-chain, let's also remove them.

relay/kusama/src/lib.rs Outdated Show resolved Hide resolved
Co-authored-by: Bastian Köcher <git@kchr.de>
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only remove from Kusama?

@acatangiu
Copy link
Contributor Author

Why only remove from Kusama?

I'm thinking we do separate PRs that follow actual on-chain upgrades + migrations for each chain.

When kusama is upgraded and we can verify these migrations have been successful we'll merge PR to remove them.

My suggestions is same process, different PR+timeline for Polkadot.

@acatangiu
Copy link
Contributor Author

referenda for upgrading Kusama: https://kusama.subsquare.io/referenda/297

@acatangiu acatangiu marked this pull request as ready for review November 9, 2023 08:32
@acatangiu
Copy link
Contributor Author

Kusama now successfully updated to spec: 1_000_000 - all these migrations have now run (and been finalized) on-chain so we can remove them.

Please note, we have to remove the session keys migration before the next release as it doesn't gracefully handle reapplying it.

@acatangiu acatangiu mentioned this pull request Nov 9, 2023
@acatangiu
Copy link
Contributor Author

@andresilva please a rank-3 review here to get this in and avoid accidents like on Westend

relay/kusama/src/paras_scheduler_migration.rs Outdated Show resolved Hide resolved
@acatangiu
Copy link
Contributor Author

hmm.. since this touches relay/ files, it needs 4 rank 3 approvals

fellows, please review!

@acatangiu
Copy link
Contributor Author

/merge

@acatangiu
Copy link
Contributor Author

I just rebased and fixed conflicts. Someone with merge rights, pls take a look and merge before we keep adding new stuff and start confusing already applied migrations with incoming new ones.

@andresilva
Copy link
Member

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) November 24, 2023 13:56
@fellowship-merge-bot fellowship-merge-bot bot merged commit 473498c into polkadot-fellows:main Nov 24, 2023
12 of 13 checks passed
@acatangiu acatangiu deleted the kusama-remove-applied-migrations branch November 24, 2023 14:17
@acatangiu
Copy link
Contributor Author

6 of 13 checks passed

this got auto-merged after rebase without running all CI tests - any way we can see if these failed or simply didn't run or what? 😃

@andresilva
Copy link
Member

You can check the CI build on master after this got merged.

@acatangiu acatangiu mentioned this pull request Jan 18, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants