Enable async backing on Kusama #90
Conversation
Sophia-Gold
force-pushed
the
sophia-async-kusama
branch
from
6584e4a
to
83e1cc9
Compare
There was a problem hiding this comment.
Looks good, although I think we should now also bump the version of the trait to (7) - at least once we have this on Polkadot as well. @tdimitrov ?
| @@ -2040,6 +2041,18 @@ sp_api::impl_runtime_apis! { | |||
| key_ownership_proof, | |||
| ) | |||
| } | |||
|
|
|||
| fn minimum_backing_votes() -> u32 { | |||
| parachains_runtime_api_impl::minimum_backing_votes::<Runtime>() | |||
There was a problem hiding this comment.
Done in 9f5cef4. Not sure why this wasn't caught by rustfmt.
When adapted the code from polkadot-fellows#88 I forgot to update the location of the credentials, so it was using review-bot which can only enable auto-merge but can not merge a ready to merge PR. Follow up to polkadot-fellows#97
Sophia-Gold
force-pushed
the
sophia-async-kusama
branch
from
a809bff
to
9f5cef4
Compare
Yes, but it is already done? |
I assume you mean 8? |
No. I meant the trait itself, but this can only be done once we also launched on Polkadot: So disregard. |
They won't be able to make use of it until we propose an update to the new parameters after this is enacted. Glutton is already upgraded in Polkadot-SDK. I'll move that here. Can your team upgrade the others? |
Yes |
This enables async backing in the Kusama runtime. Note that for candidates to actually be backed asynchronously, a subsequent governance proposal changing two new parameters is needed.