Fix api.derive.staking.eraExposure [WIP] #5813
Conversation
|
Few things need to be fixed in the derives that use eraExposure. |
|
Still need to test this against the APPS and also figure out how to get a validators own, and total since those are now deprecated from |
| @@ -48,8 +48,8 @@ function parseRewards (api: DeriveApi, stashId: AccountId, [erasPoints, erasPref | |||
| const valCut = valComm.mul(avail).div(BN_BILLION); | |||
| let staked: BN; | |||
|
|
|||
| if (validatorId === stakerId) { | |||
| staked = exposure.own.unwrap(); | |||
| if (validatorId === stakerId && (exposure as PalletStakingExposure).own) { | |||
There was a problem hiding this comment.
Not sure if this is valid. Need to double check
There was a problem hiding this comment.
I need to add the storage call to ErasStakersOverview , and do this correctly so we don't need to come back to it.
TarikGul
changed the title
skip-checks: true
…tg-derive-exposure
|
This PR brings up a good point for future derive work. What and how should compatibility be troubleshot and what is an acceptable change for upstream changes. Also how and when should they be released? |
|
|
|
closing in favor of #5815 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
closes: #5771
The following PR ensures to update the
api.derive.staking.eraExposureto use the right storage queries. For now I ensure that is is backwards compatible. Once the transition between storage entries is completely finished with polkadot,eraStakersClippedcan be completely removed.Once #5812 goes in this will have to be updated again as the types are then removed from the augmented polkadot and kusama files.