URI authority should start with word characters #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pileks
requested review from
dOrgJelli,
krisbitney,
namesty and
nerfZael
as code owners
dOrgJelli
approved these changes
Jul 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following an investigation into failing tests in our
schema-composepackage as part of work on polywrap/wrap-cli#1827 , I have found out that ourUriimplementation accepts strings like./some/pathand../some/pathas valid URIs, with theirauthoritybeing.and..respectively.This PR introduces a check wherein our
authorityneeds to start with a word character (alphanumerics and underline).I have deliberately kept it wide open beyond this, as I don't want to limit it too far while still closing this gap.
Nota Bene: This does seem to be a regression caused by us simply not having tests for this case when we were doing simplification of URI parsing: 2906388