Apply suggestions from code review

popsim-consortium · Oct 10, 2023 · 357bf42 · 357bf42
1 parent a2091db
commit 357bf42
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 21 deletions.
diff --git a/README.md b/README.md
@@ -13,7 +13,7 @@ Click [![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/g
 
 If you use ``stdpopsim`` in your work, please cite our papers:
 
-* [Adrion, etl al. (2020)](https://elifesciences.org/articles/54967)
+* [Adrion, et al. (2020)](https://elifesciences.org/articles/54967)
 * [Lauterbur, et al. (2023)](https://elifesciences.org/reviewed-preprints/84874).
 
 See [here](https://popsim-consortium.github.io/stdpopsim-docs/stable/introduction.html#citations)

diff --git a/stdpopsim/catalog/PhoSin/species.py b/stdpopsim/catalog/PhoSin/species.py
@@ -111,19 +111,10 @@
             author="Morin et al.",
             year=2021,
             doi="https://doi.org/10.1111/1755-0998.13284",
-            reasons={stdpopsim.CiteReason.ASSEMBLY},
-        ),
-        stdpopsim.Citation(
-            author="Morin et al.",
-            year=2021,
-            doi="https://doi.org/10.1111/1755-0998.13284",
-            reasons={stdpopsim.CiteReason.REC_RATE},
-        ),
-        stdpopsim.Citation(
-            author="Morin et al.",
-            year=2021,
-            doi="https://doi.org/10.1111/1755-0998.13284",
-            reasons={stdpopsim.CiteReason.REC_RATE},
+            reasons={
+                stdpopsim.CiteReason.ASSEMBLY,
+                stdpopsim.CiteReason.REC_RATE,
+            },
         ),
         stdpopsim.Citation(
             author="Robinson et al.",
@@ -165,13 +156,9 @@
             author="Robinson et al.",
             year=2022,
             doi="https://doi.org/10.1126/science.abm1742",
-            reasons={stdpopsim.CiteReason.POP_SIZE},
-        ),
-        stdpopsim.Citation(
-            author="Robinson et al.",
-            year=2022,
-            doi="https://doi.org/10.1126/science.abm1742",
-            reasons={stdpopsim.CiteReason.GEN_TIME},
+            reasons={
+                stdpopsim.CiteReason.POP_SIZE,
+                stdpopsim.CiteReason.GEN_TIME,            },
         ),
         stdpopsim.Citation(
             author="Taylor et al.",