Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction dialog with negativ quote #3370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nirus2000
Copy link
Member

@Nirus2000 Nirus2000 commented May 24, 2023

Fixes #3365

See comment
#3365 (comment)

quoteWithNegativSign.mp4

I have not found a solution for this error case.
grafik

@Nirus2000 Nirus2000 force-pushed the Fix-transaction-dialog-with-negativ-quote branch from de428df to 9b1745c Compare May 24, 2023 11:11
@Nirus2000 Nirus2000 force-pushed the Fix-transaction-dialog-with-negativ-quote branch from 9b1745c to 89610c2 Compare May 24, 2023 12:16
@stoeggich
Copy link

I don't think the fix is ​​optimal. If someone is active with options, you could not post more negative prices than in 2020 with crude oil. A truth might be better as the case is very rare

@buchen
Copy link
Member

buchen commented May 30, 2023

@stoeggich

If someone is active with options, you could not post more negative prices than in 2020 with crude oil.

Can you elaborate on your comment?
Do you have an alternative approach (for the "not optimal fix")?

In general, PP does not support options. And it should not be possible to create an inbound delivery with a negative value. Therefore I consider this a bug and would merge the fix by @Nirus2000. But I also know that many folks are using it to maintain options and I do not want to unnecessarily prevent this.

@stoeggich
Copy link

Negative courses are possible, so the possibility should be retained that you can enter them. It is probably mostly a typo, so asking if the input is correct might be an option.

But the Performance cannot be calculated for this position

@Nirus2000
Copy link
Member Author

I have never seen a negative price on securities.
However, the situation in April 2020 with crude oil cannot be transferred to stocks.
What happens is a total loss or insolvency of the company. See here

@buchen
Copy link
Member

buchen commented Jun 4, 2023

I have never seen a negative price on securities.

I believe what @stoeggich wants to say if users are using PP to model options, then it might require to have a negative asset price.

I am hesitant here. I know PP does not officially support options, but I also know that some users have found a good way to track them anyway (and live with the glitches here and there). I do not want to just shut it down.

Maybe we can have an easier transition - by default check the values, but if experimental features are activated, we are more lenient. This way we can find out the feedback from the community. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Under Consideration
Development

Successfully merging this pull request may close these issues.

0€ Inbound delivery (or: How to handle scrip dividends?)
3 participants