Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dashboard Widget often Hidden by Vertical Scrollbar #3978

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mikerion
Copy link
Contributor

@Mikerion Mikerion commented May 2, 2024

Closes #3256

@buchen
Copy link
Member

buchen commented May 9, 2024

Hi @Mikerion,

actually, looking at the layout, it makes the columns to small because it is subtracting on SPACING too much.

Now, we can throw in another 10 pixels, but I am not sure how this fixes the problem described in #3256.

There is code that - on Windows - adds additional space to make room for the vertical scroll bar. I think what we need to investigate is why that code does not work (or does not in all cases).

// On windows only, we do not have an overlay scrollbar and hence have
// to reduce the visible area to make room for the vertical scrollbar
if (Platform.OS_WIN32.equals(Platform.getOS()) && size.y > clientArea.height)
{
int width = clientArea.width - scrolledComposite.getVerticalBar().getSize().x;
size = container.computeSize(width, SWT.DEFAULT);
}

@buchen buchen added the bug label May 9, 2024
@buchen buchen self-assigned this May 9, 2024
@buchen buchen added the windows label May 9, 2024
@buchen buchen marked this pull request as draft May 9, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard Widget often Hidden by Vertical Scrollbar
2 participants