Security: Allow toString() be (in general) "ticker (name)" #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pfalcon
commented
Sep 1, 2024
pfalcon
commented
Checkbox setting in "Formatting Preferences" pages to either include/prefer ticker symbol when identifying security to user, or use just security name, as before. The motivation is that some (many?) people are actually more familiar with ticker symbols used on popular exchanges, rather than security names, which is especially true in the case of funds. However, other people may be already used to just a security name be presented by PP, so make the setting configurable. This change only implement preferences UI and API accessors, actual implementation of the "Prefer 'symbol'" setting in various places of PP UI will happen in follow-up commits.
For many people, ticker is more familiar than security name/title (this is especially true for funds). toString() is used e.g. in dropdown boxes for security selection. So, if a corresponding preference is enabled by user, include ticker in the display string. If ticker symbol is not available, or matches the security name, toString() will return just "name", as before.
|
Example of security selection dropdown before the setting activation: The setting activated: Example of security selection dropdown after the activation: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.