Statement of Assets : add total perf for TTWROR, TTWROR p.a. and IRR #4217
+78
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2570
Hello,
This is a proposition to add the TTWROR cumulated, TTWROR annualized and the IRR to the Statement of Assets totals and subtotals (main category of Taxonomy) lines.
I think there were debates about adding those totals for Abs Perf % or Capital Gains %, so those are not added (not defined). I do not know if those argument were also applicable to TTWROR and IRR, I am assuming not.
I have checked some cases with the results from the associated widget, looks ok.
Not tested are the "new values" : subtotal per category with a portfolio filter activated (I do not think such values previoulsy existed elsewhere as it requires a "double filter" taxonomy+portfolio).
I have kept two commits to highlight one issue to consider in the review : without the second commit it was not working properly because of java heap space issues. I do not get it anymore with the second commit, but maybe it is still not optimized enough ? Should a LazyPerfomanceIndex methodology be used, as it is done for Security ?
Also, this is showing 0 % for the Without Classification line, which seems wrong. Now that I think of it, Without Classification is never available as a data series. Is performance index defined for it ?
Before
After