Allow a variety of data series for statement of assets V2 #4235

mierin12 · 2024-09-16T23:29:27Z

Hello, this is a proposition to add derived data series to the statement of assets chart.

Closes #605
Closes #707
Closes #1529

Note : This is based on the PR #3754 from @shivampaw. As this PR was without update since February, I would like to propose some update if this is ok.
I fetched the PR and tried to rebase as best as I could despite the conflicts, and then add my commits. I am not sure if this was the best approach.. There are lots of commits (some cancelling each other) but at least this allows to keep @shivampaw in the contributions.
Otherwise for a clear straight forward history out of rebase/merge conflict shenanigans (but without shivampaw history): master...mierin12:portfolio:derived_data_series_in_statement_of_assets_chart_squashed

Similarities and differences with #3754:
Similarity:

TYPE_PARENT and GroupedDataSeries kept. Some of its methods are slightly changed. So the type of instance is a bit more complicated.

Differences:

Derived data series selection dialog is distinct from the usual one -> less backward compatibility issue to deal with I think. To be careful about the DataSeriesSerializer modification where we have to combined back the usual data series and those new ones (so if what I did there is incorrect, we should be wary of backward compatibility concern. But it looks ok).
In the new data series selection dialog, I am proposing a different tree order : [derived data]/Accounts & Portfolio/Account rather than Accounts & Portfolio/Account/[derived data]. I find it more intuitive. But the order can be changed.
Securities are added as a possible subtype of the derived data. I guess this is well applicable/defined ?
Enum ClientDataSeriesType done a bit differently to include also the booleans required to draw the data series either as a line or as a bar, and with an area or not.

Results:

Note on taxonomy labels:
For the selection labels, two propositions (before/after commit 14df145):

with fullPath that I kinda like but which is different than the existing behavior,
with the same behavior as the existing data series selection

Then for its legend it is simplified with the simple name of the taxonomy, and the tooltip of legend shows the full path.

Multiselection topic:
No multiselection issue I believe. And the tree is already uncluterred by the use of the two selection dialogs.
Multiselection allows here to plot several derived distinct derived data series.

Legend label:
Lots of ( ) maybe another format could be used ?

Widget Statement of Assets creating a link with the statement of assets charts seems to work well with this.

based on PR: portfolio-performance#3754

shivampaw and others added 11 commits September 16, 2024 22:16

WIP: Update data series possibilites for statement of assets

7ebc4fc

Rename a few things

c05eeb3

Refactor

d746180

Update .gitignore

e449b62

Cleanup

ff72da6

Update .gitignore

6dc6549

Use path name for classifications

377c29e

Build UUID correctly

23cd581

fix rebase issues

8f0b941

add derived data series to statements of assets chart

27c7b9a

based on PR: portfolio-performance#3754

revert to usual way of taxonomy selection search label

14df145

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow a variety of data series for statement of assets V2 #4235

Allow a variety of data series for statement of assets V2 #4235

mierin12 commented Sep 16, 2024 •

edited

Loading

Allow a variety of data series for statement of assets V2 #4235

Are you sure you want to change the base?

Allow a variety of data series for statement of assets V2 #4235

Conversation

mierin12 commented Sep 16, 2024 • edited Loading

mierin12 commented Sep 16, 2024 •

edited

Loading