Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console UI/brighter console prompt #4645

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

softwarenerd
Copy link
Contributor

This PR addresses #3970. This issue was caused by dimmed being the default value for IEditorOptions.renderFinalNewline on Linux:

/**
 * Render last line number when the file ends with a newline.
 * Defaults to 'on' for Windows and macOS and 'dimmed' for Linux.
*/
renderFinalNewline?: 'on' | 'off' | 'dimmed';

The fix was to set renderFinalNewline to on in the ConsoleInput component to override this default value.

@petetronic
Copy link
Collaborator

Nice work tracking this down, what an obscure setting. I tested this branch on Ubuntu 2024 and it addressed the prompt color issue.

Copy link
Contributor

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this on macOS and the behavior remains as expected. ✅

@softwarenerd softwarenerd merged commit 50e2f07 into main Sep 11, 2024
2 checks passed
@softwarenerd softwarenerd deleted the console-ui/brighter-console-prompt branch September 11, 2024 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants