Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify GitHub Actions Workflow to leverage draft mode status and remove merge queue #1504

Closed
karangattu opened this issue Jul 9, 2024 · 1 comment · Fixed by #1565
Closed
Assignees

Comments

@karangattu
Copy link
Collaborator

Modify GitHub Actions Workflow to accommodate the following -

  • Remove merge queue from all the jobs
  • Split the playwright jobs into multiple jobs per browser - e.g. Ubuntu 3.12 - Firefox, Ubuntu 3.12 - Chrome
    • All jobs should be done within ~ 4 mins
    • When merged we would need to adjust the required jobs in repo settings
  • If the PR is in draft mode, only run Ubuntu checks for all job types
  • If PR is not in draft mode, run all jobs
  • when switching from Draft PR -> ready for review, all jobs should be automatically run without a commit
on:
  pull_request:
    types: [opened, synchronize, reopened, ready_for_review]

Reference doc for draft conditions
Reference for PR

@karangattu karangattu self-assigned this Jul 9, 2024
@gadenbuie
Copy link
Collaborator

For extra context, here are the places where I've encountered friction with the merge queue:

  1. The tests in the merge queue are still sometimes flaky and can fail. AFAICT, you can't rerun an individual job like you can in a PR branch, so you have to add the PR back to the merge queue. If a flaky test fails on a different runner, you end up repeating the process.

    With PR checks, I can re-run individual checks until I get an overall green check before merging.

  2. The merge queue tends to obscure the workflow. I find it harder to see the checks in general, but they're impossible to review on GitHub's mobile app. I often look through failing checks or trigger a re-run from my phone for PR checks, but can't do this for merge queue checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants