Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Minimize jobs in draft PR mode. Maximize parallel jobs for ready PR. Remove merge queue #1565

Merged
merged 95 commits into from
Jul 26, 2024
Merged

chore(ci): Minimize jobs in draft PR mode. Maximize parallel jobs for ready PR. Remove merge queue #1565

merged 95 commits into from
Jul 26, 2024

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Jul 23, 2024 •
edited
Loading

Fixes #1504

Findings....

  • Historically, we have never checked on windows or macos
    • Windows is slow to install, making the job 5+ mins
  • ui.Chat has a hard time loading on CI. So the timeouts are set to 30s for the initial checks. Probably only first one is needed, but the second ones are there to handle the extra steps.
  • When running 4 parallel workers, jobs were being stopped without notice. This could be due to too much resource usage and the job is auto killed. Moved back down to 3 workers.
  • To help reduce resource usage, only chrome will record its sessions and keep on failure
    • webkit has terrible performance (x5+) when recording is done. **shame-bell.png
  • Testing could be even faster if we went back to a page fixture that exists per session (not just function). However, video recording does not work (page.video is None).
  • Using uv to install rather than pip reduces install time (including python) from 90s to 30s 🎉
  • Options for better debugging...

@schloerke
Use kebab style arg
7fc85ad 
Related: pypa/gh-action-pypi-publish#125
@schloerke
Move playwright tests from pytest.yaml to end-to-end.yaml
63923bf
@schloerke
Reduce jobs created if status is draft. Test full
3d8ef6e
@schloerke
Update end-to-end.yaml
4a6281f
@schloerke
bash quote typo
a2e1a71
@schloerke
Actually test on os value
e32b840
@schloerke
Add os value support
5260d98
@schloerke
debug if inline if values are converted to boolean or the value is kept
2dde152
@schloerke
Try using exclusion approach to avoid needing config pre-job
0ba8293 
Related: https://stackoverflow.com/a/73822998/591574
@schloerke
Update end-to-end.yaml
6aea30d
@schloerke
Exclude macos and windows and py 3.9, 3.10, 3.11 on draft
39512c8
@schloerke
Update pytest.yaml
8296477
@schloerke
Try installing packags via uv and not pip
a86e385
@schloerke
Add a virtual environment and enable it before calling make commands
2ad4c03
@schloerke
Update end-to-end.yaml
5118128
@schloerke
Update action.yaml
f3dfadf
@schloerke
Call make commands directly
617c229
@schloerke
Update action.yaml
5afc91e
@schloerke
Try activating and calling make
4be84fb
@schloerke
Update action.yaml
daddcfe
@schloerke
Update action.yaml
af6af50
@schloerke
Update action.yaml
bf36cd3
@schloerke
Use venv folder for docs
b4f72a6
@schloerke
Update action.yaml
5a709ae
@schloerke
Update action.yaml
731fd72
@schloerke
Use . venv/bin/activate syntax
b452d47
@schloerke
Do not require make playwright-deploys to install rsconnect
1caa908
@schloerke
rsconnect_python not rsconnect
74ae8ad
@schloerke
Try with 4 processes
09ef1ef
@schloerke
Update end-to-end.yaml
1bf23b3
@schloerke
Use page_chat to slow down default wait time across board
bb73e50
@schloerke
Update test_chat_append_user_msg.py
43b4a27
@schloerke
Add a wait_for_idle_app() at beginning of each chat test
df2a0cb
@schloerke
Try waiting for shiny elements to have been bound before waiting for …
baf093a 
…non-busy
@schloerke
Rather than a function, just set the timeout variable directly
17fcb22
@schloerke
Allow slower execution time; Do not use 4 processes
a73a00e
@schloerke
Disable playwright-diagnostics for webkit as it's VERY slow
1f436cc 
Related microsoft/playwright#18119
@schloerke
Update action.yaml
1dfc308
@schloerke
Wait for chat apps to perform initial load before attempting to type
8738c85
@schloerke
Add reruns for failed tests on CI
e9e6917
@schloerke
Add back page size reset and console monitoring
727d86b
@schloerke
Trying to keep memory usage down. Do not keep args
2be3239
@schloerke
lint
8924acd
@schloerke
Do not record on firefox
679ad95
@schloerke
Only record console messages on chromium
7eabc3b
@schloerke
Update pytest.yaml
6c1e9b5
@schloerke
Try older versions of ubuntu
f29deb0
@schloerke
Rearrange diagnostic arg locations to avoid needing to override values
ebaa5e1
@schloerke
Try not using custom page object
2efa0b2
@schloerke
Revert ubuntu change
1d9e1e2
@schloerke
Update pytest.yaml
43947ae
@schloerke
Remove custom page object with browser console message tracking
1d5a5c6
@schloerke
lints
11ce472
@schloerke
More timeouts settings
ba436a3
@schloerke
Remove unnecessary shell: bash
5bb1577
@schloerke
Clean up file
1e08f8f
@schloerke schloerke mentioned this pull request Jul 26, 2024
Closed
2 tasks
@schloerke schloerke merged commit 4d2056e into main Jul 26, 2024
48 checks passed
@schloerke schloerke deleted the ci_split_jobs branch July 26, 2024 13:13
@schloerke schloerke mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify GitHub Actions Workflow to leverage draft mode status and remove merge queue
2 participants
@schloerke @wch