Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api!: Merge RendererBase class into Renderer #1032

Merged
merged 12 commits into from
Jan 19, 2024
Merged

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Jan 18, 2024

  • Removes RendererBase class.
  • RendererBaseT -> RendererT
  • Hard deprecate RenderFunction / RenderFunctionAsync
    • The RenderFunction.__call__(self) method was an @abstractmethod. This method's signature and intent did not agree with Renderer.__call__(self, _fn: ValueFn[...]).
    • This might occur with older versions of shinywidgets with newer versions of shiny.
    • This goes against Restore RenderFunction, RenderFunctionSync, and RenderFunctionAsync #1003 in that now the methods are hard deprecated. But at least the message is much clearer on how to move forward.

@schloerke schloerke merged commit 96a6279 into main Jan 19, 2024
24 of 26 checks passed
@schloerke schloerke deleted the renderer_class_only branch January 19, 2024 17:34
schloerke added a commit that referenced this pull request Jan 19, 2024
* main: (26 commits)
  api!: Merge RendererBase class into Renderer (#1032)
  chore(render.display): Improve error message (#1020)
  `express.ui.page_opts(title = ...)` now always generates a header (#1016)
  api!: `Renderer.auto_output_ui()` drops `id` arg. Make `RendererBase.output_id` a non-namespaced value. (#1030)
  fix(page_sidebar): Add semicolon to end style declaration (#1027)
  chore: Remove experimental from app (#1028)
  chore: Expose `render.renderer.RendererBaseT` and do not require `| None` when defining Renderer types (#1026)
  bug: Restore legacy renderers while packages transition (#1023)
  Update deploy test apps to use render.code
  Update changelog
  Provide useful message in Express when `input` was not imported (#994)
  Calculate coordinate mapping after drawing figure (#999)
  Remove `express.ui.output_*` functions, add `shiny.express.render` (#1018)
  fix: Do not allow for renderer's to be given to reactive effects (#1017)
  Truncate the requirements.txt file before deploys (#998)
  Update changelog
  Fixes for flake8 (#1012)
  Pin starlette version below 0.35 (#1009)
  Remove shiny express warning
  Cause RecallContextManagers to run when used without `with` (#992)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant