For Express, emit message if need to upgrade rsconnect-python #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshotwell
reviewed
Mar 20, 2024
shiny/_main.py
Outdated
|
|
||
| try: | ||
| package_version = version(PACKAGE_NAME) | ||
| print(package_version) |
There was a problem hiding this comment.
Oh oops, I had deleted it on my local copy of the file, but forgot to commit. 🤦
shiny/_main.py
Outdated
|
|
||
| from importlib.metadata import PackageNotFoundError, version | ||
|
|
||
| def _safe_int(x: str) -> int: |
There was a problem hiding this comment.
I think we already have an indirect dependency on packaging, do we want to make it direct and use their version parsing?
from packaging.version import parse
from importlib.metadata import PackageNotFoundError, version
import sys
try:
installed_version = parse(version(PACKAGE_NAME))
required_version = parse(MIN_VERSION)
if installed_version < required_version:
...
There was a problem hiding this comment.
Good call -- I see that htmltools uses packaging to check versions, so I've updated the code as you suggested.
schloerke
added a commit
to joesho112358/py-shiny
that referenced
this pull request
Mar 23, 2024
* main: (24 commits) chore: Disable broken test on CI; Fix broken docs entries (posit-dev#1241) Add back missing session methods (posit-dev#1239) Add kitchensink tests for valuebox (posit-dev#1229) For Express, emit message if need to upgrade rsconnect-python (posit-dev#1233) feat: Editable data frame (posit-dev#1198) Add tests for shiny_mode comment detection fix(input_dark_mode): Allow users to customize `style` attribute (posit-dev#1207) chore(get_current_session): Return default session if current is explicitly None (posit-dev#1086) chore: use dev htmtlools (posit-dev#1228) feat(layout_columns): Use `sm` as the default `col_widths` breakpoint (posit-dev#1222) feat: ensure min/max height args on `value_box()` and column layouts (posit-dev#1223) fix(static_assets): Need the directory containing the `app.py`, not the file itself (posit-dev#1219) Update bslib and shiny dependencies (posit-dev#1221) Update docstring and give hint for mypy Add support for Shiny Express in Quarto Dashboards, take 2 (posit-dev#1217) Force UTF-8 for Shiny Express on Windows (posit-dev#1203) Typing fixes feat(card): Report full screen state as a Shiny input (posit-dev#1215) Use TypeScript strict mode (posit-dev#1208) Update author email ...
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1232.
When a user runs
shiny run app.pyon a Shiny Express app, this checks the version of the rsconnect-python package.If (A) rsconnect-python is installed and (B), the version is less than 1.22.0, then this will print a message to stderr like this, and then it will run the app as usual.