Add return type for _task()
#1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the error we were seeing with pyright 1.1.369 was due to a bug: microsoft/pyright#8229 |
schloerke
added a commit
to machow/py-shiny
that referenced
this pull request
Jul 2, 2024
* main: fix(tests): dynamically determine the path to the shiny app (posit-dev#1485) tests(deploys): use a stable version of html tools instead of main branch (posit-dev#1483) feat(data frame): Support basic cell styling (posit-dev#1475) fix: support static files on pyodide / py.cafe under a prefix (posit-dev#1486) feat: Dynamic theming (posit-dev#1358) Add return type for `_task()` (posit-dev#1484) tests(controls): Change API from controls to controller (posit-dev#1481) fix(docs): Update path to reflect correct one (posit-dev#1478) docs(testing): Add quarto page for testing (posit-dev#1461) fix(test): Remove unused testrail reporting from nightly builds (posit-dev#1476)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that is flagged by pyright 1.1.369.