Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Export ui.card_body() #1506

Merged
merged 6 commits into from
Jul 17, 2024
Merged

feat: Export ui.card_body() #1506

merged 6 commits into from
Jul 17, 2024

Conversation

gadenbuie
Copy link
Collaborator

@gadenbuie gadenbuie commented Jul 9, 2024 •
edited

Fixes #1128

Makes shiny.ui.card_body() and shiny.express.ui.card_body() public.

Also includes a few small maintenance adjustments:

  1. We now conditionally include the .bslib-gap-spacing class if fillable=True. (This matches changes in bslib.)
  2. A few small docstring edits.

@gadenbuie gadenbuie requested review from wch and jcheng5 July 16, 2024 20:08
@gadenbuie gadenbuie mentioned this pull request Jul 16, 2024
Merged
1 task
@gadenbuie gadenbuie added this pull request to the merge queue Jul 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2024
@gadenbuie gadenbuie merged commit 7be5c87 into main Jul 17, 2024
30 checks passed
@gadenbuie gadenbuie deleted the feat/ui-card-body branch July 17, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

@jcheng5 jcheng5 Awaiting requested review from jcheng5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export ui.card_body()
3 participants
@gadenbuie @wch @schloerke