bug(data frame): Make sure all original patch locations exit saving state #1529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original posted by @maxmoro in #1449 (comment) and https://discord.com/channels/1109483223987277844/1258826016403623976/1258826018181877823
If cell
[x,y]
was edited & saved, and the patch function returned any cell other than[x,y]
, the original cell location would never leave the saving state.Now, if the cell is in the saving state, the cell will be returned to the ready state with the original value. Immediately after this, all patches will be saved. While not optimal, the simplicity is effective and the data that is reset is done in the same execution tick.