-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rsconnect json files and folium tests #928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wch The deploy of express apps to
|
@karangattu Do you know how how the deployment script determines which version of Shiny to use? When I deploy locally, I'm able to reproduce the problem if I have this as my
This will install Shiny from PyPI, and that version of Shiny does not have a However, if I change the
This installs Shiny from GitHub, and that version of Shiny does have In the Connect logs, if you look at "Python environment restore" and search for (One more note: even if it has 0.6.1.9000, it is possible that it's using an older commit, before the I don't know why this would be different between shinyapps.io and a Connect server, though. |
The requirements.txt contains the following for each express app
As for the version the deploy script uses, it runs the setup on the dev version, as show in this GitHub actions workflow step so I assume it is using the develop version. |
The
|
Looking at the SHA, the connect env had the shiny version cached from 13 days ago.. I don't know why it is not picking up the latest version |
Fixed it by removing |
* main: (24 commits) Use dynamic version of py-shiny for deploy tests (#970) Add underscores to hide some imports (#978) Add rsconnect json files(shinyapps.io tests) and folium tests (#928) Express' `value_box()` no longer includes named positional args (#966) Include `tooltip()` and `popover()` in express (#949) Remove extra call to run_express() Call `tagify()` early to intercept `AttributeErrors` (#941) Don't pass sidebar twice to navbar_page Update changelog Update changelog Switch from `requests` to `urllib` (#940) Bump version to 0.6.1.1 Fix docstring for page_opts Fix API doc sections for Express Smarter, lazier, and more complete page default/api for express (#893) Change `express.layout` to `express.ui` (#904) Remove `@output` from examples (#790) feat: Allow for `App` `server=` to take `input` only (#920) Add fixes for type stub generation (#828) Move quarto express docs to bottom ...
* main: Use dynamic version of py-shiny for deploy tests (#970) Add underscores to hide some imports (#978) Add rsconnect json files(shinyapps.io tests) and folium tests (#928) Express' `value_box()` no longer includes named positional args (#966) Include `tooltip()` and `popover()` in express (#949)
Add tests for
render.display
for shiny express apps.Also, enable deploy tests to
shinyapps.io
in addition toconnect