-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add render.download
, take 2
#977
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee4bf1b
to
4ddeb6c
Compare
schloerke
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (given cosmetic tweaks)
Going to hold the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
render.download
, and supersedes #967.The existing API is to use
session.download
, like this:This is quite a bit different from all other outputs, because it relies on the
session
object. This also doesn't work for Express apps, because there isn't asession
object available. (I'll note here that it would be possible to add asession
object that could be imported fromshiny.express
, but the change in this PR is a better one.)With this PR, the app uses
render.download
instead ofsession.download
:I think this makes more sense from the app author's perspective.
In an Express app, the code would look like this (the button is automatically inserted in the UI):
With Express, the label can also be set with
label
:Currently,
label
is the only parameter fordownload_button
that's exposed inrender.download
. There are others, likeicon
andclass_
which are relatively commonly used -- maybe it's best to wait until we resolve #971 before we decide what to do with these other parameters.