Don't collapse whitespaces inside comments #17

posthtml · Feb 9, 2016 · a916e20 · a916e20
1 parent 873a1f2
commit a916e20
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/modules/collapseWhitespace.es6 b/lib/modules/collapseWhitespace.es6
@@ -1,3 +1,6 @@
+import { isComment } from '../helpers';
+
+
 const noWhitespaceCollapseElements = ['script', 'style', 'pre', 'textarea'];
 
 
@@ -8,7 +11,7 @@ export default function collapseWhitespace(tree, options, collapseType) {
     }
 
     tree.forEach((node, index) => {
-        if (typeof node === 'string') {
+        if (typeof node === 'string' && ! isComment(node)) {
             node = collapseRedundantWhitespaces(node, collapseType);
         }
 

diff --git a/test/modules/collapseWhitespace.js b/test/modules/collapseWhitespace.js
@@ -17,10 +17,13 @@ describe('collapseWhitespace', () => {
             );
         });
 
-        it('should not collapse whitespaces inside <script>, <style>, <pre>, <textarea>', () => {
+        it('should not collapse whitespaces inside comments, <script>, <style>, <pre>, <textarea>', () => {
             return init(
-                ' <script> alert() </script>  <style>.foo  {}</style> <pre> hello <b> , </b> </pre> <textarea> world! </textarea> ',
-                '<script> alert() </script><style>.foo  {}</style><pre> hello <b> , </b> </pre><textarea> world! </textarea>',
+                ` <script> alert() </script>  <style>.foo  {}</style> <pre> hello <b> , </b> </pre>
+                  <div> <!--  hello   world  --> </div>
+                  <textarea> world! </textarea> `,
+                '<script> alert() </script><style>.foo  {}</style><pre> hello <b> , </b> </pre>' +
+                '<div><!--  hello   world  --></div><textarea> world! </textarea>',
                 options
             );
         });