Merge pull request #181 from SukkaW/fix-180

Fix(#180): exclude "sizes" from attributesWithLists
posthtml · Apr 2, 2022 · e4eedd0 · e4eedd0
2 parents 2a6ad50 + 00e7ac9
commit e4eedd0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/modules/collapseAttributeWhitespace.es6 b/lib/modules/collapseAttributeWhitespace.es6
@@ -6,7 +6,13 @@ export const attributesWithLists = new Set([
     'rel', // a, area, link
     'ping', // a, area
     'sandbox', // iframe
-    'sizes', // link
+    /**
+     * https://github.com/posthtml/htmlnano/issues/180
+     * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link#attr-sizes
+     *
+     * "sizes" of <img> should not be modified, while "sizes" of <link> will only have one entry in most cases.
+     */
+    // 'sizes', // link
     'headers' // td, th
 ]);
 

diff --git a/test/modules/sortAttributesWithLists.js b/test/modules/sortAttributesWithLists.js
@@ -11,6 +11,16 @@ describe('sortAttributesWithLists', () => {
         );
     });
 
+    it('issue #180', () => {
+        return init(
+            '<img sizes="(min-width: 300px) 200px, 100px">',
+            '<img sizes="(min-width: 300px) 200px, 100px">',
+            {
+                sortAttributesWithLists: 'alphabetical',
+            }
+        );
+    });
+
     it('frequency', () => {
         return init(
             '<div class="foo baz bar"></div><div class="bar foo"></div>',