Fix CGM export dependencies issues #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CGM export Signed-off-by: Romain Courtier <romain.courtier@rte-france.com>
Signed-off-by: Romain Courtier <romain.courtier@rte-france.com>
zamarrenolm
reviewed
Sep 4, 2024
...ersion/src/test/java/com/powsybl/cgmes/conversion/test/export/CommonGridModelExportTest.java
Show resolved
Hide resolved
Signed-off-by: Romain Courtier <romain.courtier@rte-france.com>
…ependencies, and prevails on the CgmesMetadataModel network extension if both are present Signed-off-by: Romain Courtier <romain.courtier@rte-france.com>
|
zamarrenolm
approved these changes
Sep 13, 2024
geofjamg
pushed a commit
that referenced
this pull request
Sep 18, 2024
Signed-off-by: Romain Courtier <romain.courtier@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Currently, when the user performs a CGM export by setting the CGM_EXPORT parameter to true, a common SV model is exported for the main network and updated SSH models for the subnetworks.
However, it has been reported that 2 dependencies are missing:
What is the new behavior (if this is a feature change)?
The missing dependencies have been added.
Note that if the same TP_BD model is used by multiple IGM (which is most likely the case), it will appear only once in the SV model as a dependentOn. Also, if the TP_BD model is provided both through the parameter and via the network extension, the parameter will prevail.
Does this PR introduce a breaking change or deprecate an API?
Other information: