Add builders from existing objects #3130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-rte
force-pushed
the
add_builders_from_existing_objects
branch
2 times, most recently
from
2a7fd64
to
cd5ce9d
Compare
bc-rte
force-pushed
the
add_builders_from_existing_objects
branch
from
9645e84
to
4bfb458
Compare
flo-dup
requested changes
Sep 11, 2024
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/LineAdderImpl.java
Outdated
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/AdderUser.java
Outdated
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/CurrentLimitsNestedAdder.java
Outdated
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/AdderUser.java
Outdated
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/NestedAdder.java
Outdated
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/CurrentLimitsPayload.java
Outdated
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/Network.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/CurrentLimitsNestedAdderImpl.java
Outdated
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/LineAdder.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/TemporaryLimitNestedAdderImpl.java
Outdated
Show resolved
Hide resolved
bc-rte
force-pushed
the
add_builders_from_existing_objects
branch
from
b431abd
to
56b0abe
Compare
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
bc-rte
force-pushed
the
add_builders_from_existing_objects
branch
2 times, most recently
from
6a8e1fb
to
c57b1cf
Compare
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
bc-rte
force-pushed
the
add_builders_from_existing_objects
branch
from
c57b1cf
to
4ebfc62
Compare
…ity curve as template Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
bc-rte
force-pushed
the
add_builders_from_existing_objects
branch
2 times, most recently
from
53da2eb
to
c903d96
Compare
bc-rte
changed the title
bc-rte
changed the title
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
bc-rte
force-pushed
the
add_builders_from_existing_objects
branch
from
c903d96
to
347db8e
Compare
bc-rte
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
This PR introduces adder initialized by copying an existing component.
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
the
NetworkImpl::newLinemethod now has two parametric implementations with one parameter.Users that used
network.newLine(null)need to cast nullnetwork.newLine((String) null)in order to pass compilationOther information:
This PR is inspired from previous work there.