Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using horizontal & vertical layouts for ZoneGraph #518

Merged
merged 41 commits into from
Sep 22, 2023
Merged

Conversation

tadam50
Copy link
Contributor

@tadam50 tadam50 commented May 4, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
No layouts for Zone graph are available

What is the new behavior (if this is a feature change)?
Provide horizontal and vertical layouts for Zone graph

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@tadam50 tadam50 self-assigned this May 4, 2023
@tadam50 tadam50 added the SLD label May 4, 2023
@flieks
Copy link

flieks commented May 11, 2023

This is great, thanks!

@tadam50, just have 1 question. I see there is a horizontal example and vertical example. But can vertical and horizontal layouts be combined in 1 svg ?

For example we have 12 substations, then ideally we want to have 3 rows with each 4 substations...

@flo-dup
Copy link
Contributor

flo-dup commented May 15, 2023

@flieks Indeed, this would be a lot better! But this would be in another PR, this PR introduces a very basic version to start simple.

I'll write an issue for that feature, it would be nice if you could add some details about what you had in mind

@flieks
Copy link

flieks commented Jun 13, 2023

@flo-dup @tadam50 Thanks for starting this PR, sorry for late reply
This is kind of what we are trying to achieve:
image
Dont mind the green and orange borders. This is to group substations. The green ones are substations.

I am trying to click on this one in the docs
image
but the page is not there yet. I guess it will come with this PR.

Because we need the vertical layout as you can see, our main substation busbars are vertical lines and then the connections that go to other substations are horizontal lines. It would be awesome if we could achieve something like this. Would this be possible with this PR or maybe another one ? Maybe we can help if you point us in the right direction of what should be changed/coded to get this working ?

i puted this info condensed in the other PR 520 also

Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your nice work!
I didn't have time to finish my review, to be continued :)

@tadam50 tadam50 force-pushed the draw_zone_graph branch 2 times, most recently from 578d71a to 1b60432 Compare July 7, 2023 08:21
@tadam50 tadam50 force-pushed the draw_zone_graph branch 3 times, most recently from 9df67bc to 5b54803 Compare July 25, 2023 14:18
Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the huge amount of work you have put in this PR.
I made a minor comment, I would like to discuss it further with you because I do not get why there is a difference between substation and zone regarding layout naming (and furthermore I may be to blame here!).

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.5% 96.5% Coverage
0.0% 0.0% Duplication

@tadam50 tadam50 marked this pull request as ready for review August 4, 2023 16:41
@tadam50 tadam50 force-pushed the draw_zone_graph branch 2 times, most recently from ce57421 to ee267c8 Compare September 11, 2023 14:25
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
…interfaces

Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
…oSnakeLines

Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.5% 96.5% Coverage
0.0% 0.0% Duplication

@So-Fras So-Fras self-requested a review September 22, 2023 13:16
@So-Fras
Copy link
Member

So-Fras commented Sep 22, 2023

Some configurations (VH and HV) do not offer a clear and completly satisfying display. But this PR is a first attempt to display multi-substation graphs. It will be followed by another PR to represent multi-substation graphs according to a matrix design.

@So-Fras So-Fras merged commit 517b281 into main Sep 22, 2023
6 checks passed
@So-Fras So-Fras deleted the draw_zone_graph branch September 22, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants