SLD : add LCC_CONVERTER_STATION component type #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
So-Fras
requested changes
Jul 21, 2023
| if (lccConverterStation != null) { | ||
| LineDiagramData<LccConverterStation> lccDiagramData = LineDiagramData.getOrCreateDiagramData(lccConverterStation); | ||
| int danglingLineSeq = getMaxSeq(lccDiagramData.getPoints(diagramName)) + 1; | ||
| DiagramPoint vcsPoint = offsetPoint.newDiagramPoint(lccNode.getX(), lccNode.getY(), danglingLineSeq); |
There was a problem hiding this comment.
A very minor remark: could you please rename vcsPoint in lccPoint just to be consistent with the notations?
By the way, I am under the impression that vcs should be vsc instead in applyLayoutOnVscConverterStation for example.
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
|
Kudos, SonarCloud Quality Gate passed! |
So-Fras
approved these changes
Jul 21, 2023
antoinebhs
added a commit
to gridsuite/gridstudy-app
that referenced
this pull request
Nov 7, 2023
…STATION were introduced in powsybl-diagram by powsybl/powsybl-diagram#537
antoinebhs
added a commit
to gridsuite/gridstudy-app
that referenced
this pull request
Nov 7, 2023
…STATION were introduced in powsybl-diagram by powsybl/powsybl-diagram#537
antoinebhs
added a commit
to gridsuite/gridexplore-app
that referenced
this pull request
Nov 7, 2023
…STATION were introduced in powsybl-diagram by powsybl/powsybl-diagram#537.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Only VSC_CONVERTER_STATION can be used
What is the new behavior (if this is a feature change)?
LCC_CONVERTER_STATION can be used too