[SLD] Add label on all nodes if requested #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
So-Fras
requested changes
Dec 11, 2023
| @@ -35,7 +35,7 @@ public abstract class AbstractTestCase { | |||
| private static final Pattern SVG_FIX_PATTERN = Pattern.compile(">\\s*(<\\!\\[CDATA\\[.*?]]>)\\s*</", Pattern.DOTALL); | |||
|
|
|||
| protected boolean debugJsonFiles = false; | |||
| protected boolean debugSvgFiles = false; | |||
| protected boolean debugSvgFiles = true; | |||
There was a problem hiding this comment.
I think that debugSvgFiles should be equal to false.
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
So-Fras
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Only feeder and bus bar section names are displayed
What is the new behavior (if this is a feature change)?
EquipmentNodes ifSvgParameter::isDisplayEquipmentNodesLabel: switches and internal two-winding transformers then have their name or id displayedConnectivityNodes ifSvgParameter::isDisplayConnectivityNodesId(andSvgParameter::isShowInternalNodes)Does this PR introduce a breaking change or deprecate an API?