OperatingStatus extension is on an Identifiable #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
requested changes
Apr 2, 2024
...diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
...diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
requested changes
Apr 2, 2024
...diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
...diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
...diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
...diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
...diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
...diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
approved these changes
Apr 3, 2024
| break; | ||
| } | ||
| case HVDC -> addOperatingStatusDecorator(nodeDecorators, node, direction, network.getHvdcLine(feederNode.getEquipmentId())); | ||
| default -> { /* Do nothing */ } |
There was a problem hiding this comment.
It was a code smell before because you did nothing without telling why. Now that you added the comment it ensures that it was not an empty statement by mistake. But it's more valuable to also add more context like "no decorator for other feeder types"
| switch (operatingStatus.getStatus()) { | ||
| case PLANNED_OUTAGE -> nodeDecorators.add(getBranchStatusDecorator(node, direction, PLANNED_OUTAGE_BRANCH_NODE_DECORATOR)); | ||
| case FORCED_OUTAGE -> nodeDecorators.add(getBranchStatusDecorator(node, direction, FORCED_OUTAGE_BRANCH_NODE_DECORATOR)); | ||
| default -> { /* Do nothing */ } |
There was a problem hiding this comment.
Same here, and as there is only one other enum value, it's better to have it displayed instead of default
Suggested change
| default -> { /* Do nothing */ } | |
| case IN_OPERATION -> { /* no decorator for in operation equipments */ } |
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The OperatingStatus extension on an HVDCLine is currently read on the ConverterStation. Thus the code always returns null and the extension is never read.
What is the new behavior (if this is a feature change)?
The extension is read on the HVDCLine.
Does this PR introduce a breaking change or deprecate an API?