Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAD] Fix edge infos #629

Merged
merged 6 commits into from
Jul 3, 2024
Merged

[NAD] Fix edge infos #629

merged 6 commits into from
Jul 3, 2024

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Jul 2, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?

  • The text used for edge infos was red or green depending on the corresponding positive/negative value
  • If the value is NaN, an out-arrow is still displayed

What is the new behavior (if this is a feature change)?

  • The text used for edge infos is having the same colour as the corresponding arrow
  • If the value is NaN, no arrow is drawn

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)
See the migration guide

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup requested a review from So-Fras July 2, 2024 13:59
Copy link

sonarcloud bot commented Jul 3, 2024

@flo-dup flo-dup merged commit 54de501 into main Jul 3, 2024
7 checks passed
@flo-dup flo-dup deleted the nad_fix_edge_infos branch July 3, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants