Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip validation #49

Merged
merged 6 commits into from
Apr 21, 2017
Merged

Add skip validation #49

merged 6 commits into from
Apr 21, 2017

Conversation

bryanwweber
Copy link
Member

@bryanwweber bryanwweber commented Apr 21, 2017 •
edited
Loading

  • Tests added
  • Added entry into CHANGELOG.md

Changes proposed in this pull request:

  • Add keyword to totally skip the validation step when loading a ChemKED file
  • Revert support for Python 2.7 because the keyword-only argument for the initializer is supported by Python 3.0+

In the future, we might want to consider disabling parts of the validation, but as a global solution, this works pretty well 😃

@pr-omethe-us/chemked

@bryanwweber
Revert "Add back support for Python 2.7"
693dd13 
Take Python 2.7 support out again to allow using Python 3-only
features

This reverts commit 740db45.
@bryanwweber
Force warnings in tests to always appear
ffb6406
@bryanwweber
Revert "Have to allow Python 2.7 as an option in conda builds duh..."
07dd17b 
No longer needed as Python 2 is no longer supported

This reverts commit 78d38a9.
@bryanwweber
Add kwarg to skip validation of ChemKED files
d55d64c 
Use of keyword-only argument means that this is Python 3 only
@bryanwweber
Update CHANGELOG with skip_validation
9c06624
@bryanwweber bryanwweber mentioned this pull request Apr 21, 2017
Open
@codecov
Copy link

codecov bot commented Apr 21, 2017 •
edited
Loading

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #49   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         358    354    -4     
  Branches      101     99    -2     
=====================================
- Hits          358    354    -4
Impacted Files Coverage Δ
pyked/chemked.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1bab0...d21808c. Read the comment docs.

kyleniemeyer
kyleniemeyer approved these changes Apr 21, 2017
View reviewed changes
Copy link
Member

@kyleniemeyer kyleniemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kyleniemeyer kyleniemeyer merged commit 97294b7 into pr-omethe-us:master Apr 21, 2017
@bryanwweber bryanwweber deleted the add-skip-validation branch April 22, 2017 01:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleniemeyer kyleniemeyer kyleniemeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanwweber @kyleniemeyer