Pyteck Bug Fixes #23
Open
Pyteck Bug Fixes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking for the 'target species' for ignition detection, the species key is now used to translate between the name of the species requested by the experimental data and the name used in the model. This is to resolve an issue where pyteck could not find the requested species and was falling back to pressure.
Instead of using the first time in the list of ignition delays returned from get_ignition_delay, the last time is now used since this seems to be the 'max' peak for each of the ignition types based on the way that the ignition delays list is populated. This is to resolve an issue where pyteck was always taking the earliest peak rather than the max peak for specific ignition types.