Use inspect.signature() for Python3 and up #551
Conversation
13steinj
force-pushed
the
fixargspec
branch
2 times, most recently
from
2b18ed4
to
d89a791
Compare
| @@ -48,7 +48,14 @@ def alias_function(function, class_name): | |||
| """ | |||
| @wraps(function) | |||
| def wrapped(self, *args, **kwargs): | |||
| func_args = inspect.getargspec(function).args | |||
| if six.PY3 and not hasattr(sys, 'pypy_version_info'): | |||
There was a problem hiding this comment.
Can we extract func_args into it's own function to avoid repetition?
There was a problem hiding this comment.
@bboe sure :P would you like it in this file somewhere or in internal.py?
E: or somewhere else, of course.
There was a problem hiding this comment.
It could be another nested function within alias_function since it doesn't really fit anywhere else at the moment. If we used it elsewhere, I think internal would make sense.
There was a problem hiding this comment.
It's used in both alias_function and require_captcha, so internal?
There was a problem hiding this comment.
Didn't catch that. Yes that would be appropriate.
On Nov 22, 2015 3:38 PM, "13steinj" notifications@github.com wrote:
In praw/decorators.py
#551 (comment):@@ -48,7 +48,14 @@ def alias_function(function, class_name):
"""
@wraps(function)
def wrapped(self, _args, *_kwargs):
func_args = inspect.getargspec(function).argsif six.PY3 and not hasattr(sys, 'pypy_version_info'):It's used in both alias_function and require_captcha, so internal?
—
Reply to this email directly or view it on GitHub
https://github.com/praw-dev/praw/pull/551/files#r45566954.
|
Awesome! Thanks for the pull request. Just one small issue to address then it'll be good to go. The nightly build (3.6 alpha) won't pass until flake8 is updated to support the same change, but that's okay for us. |
13steinj
force-pushed
the
fixargspec
branch
4 times, most recently
from
5f1001e
to
569745b
Compare
|
@bboe done...But I've no idea why Travis is messing up. And on travis it's showing an imaginary commit. |
13steinj
force-pushed
the
fixargspec
branch
2 times, most recently
from
d196120
to
a38373f
Compare
`inspect.getargspec()` is soon to be deprecated in favor of `inspect.signature()`. `inspect.signature` was not backported for Python2 or PyPy, so we will keep using `inspect.getargspec()` for that. Resolves praw-dev#541
|
@bboe I fixed it, but I couldn't add it to internal. I had to add it to decorator_helpers because when getting it from internal there was essentially a weird import loop. |
Use inspect.signature() for Python3 and up
|
Great work! |
inspect.getargspec()is soon to be deprecated in favor ofinspect.signature().inspect.signaturewas not backported for Python2, so we will keep usinginspect.getargspec()for that.Resolves #541