feat: Preset simple DB #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to hold merging this until https://github.com/preset-io/superset-shell/pull/1466/ has been deployed to production. |
AAfghahi
approved these changes
Dec 9, 2022
betodealmeida
commented
Jan 20, 2023
|
Depends on apache/superset#22806 being deployed. |
|
@betodealmeida you can actually merge this now. Public examples works very similarly to superset in shell. We basically have to say, this is the sha to use for all public examples. If that doesn't happen we'll use the existing SHA. So after merging this, you'll need to create a PR that will update public examples in superset shell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new DB for CSV file uploads.