Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use context properties where context methods are deprecated #594

Merged
merged 2 commits into from
Oct 29, 2023
Merged

chore: use context properties where context methods are deprecated #594

merged 2 commits into from
Oct 29, 2023

Conversation

filiptammergard
Copy link
Contributor

But keep supporting the methods for now.

I think this might be considered a chore as it won't affect users of the plugin until ESLint v10 is released.

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

⚠️ No Changeset found

Latest commit: c12b522

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JounQin JounQin requested a review from BPScott October 26, 2023 07:47
@BPScott
Copy link
Member

BPScott commented Oct 27, 2023

Generally yes and thanks! I'll test this with old and new eslint versions and merge if it all looks good over the weekend

adjust comments
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed up a tweak to the comments, to avoid having long lines - I prefer comments living above code rather than at the end of a code line

@BPScott BPScott merged commit e65b459 into prettier:master Oct 29, 2023
4 checks passed
@filiptammergard
Copy link
Contributor Author

Great @BPScott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants