Run prettier instance in worker_threads
#3016
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /src/worker/*.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| import { Worker } from "worker_threads"; | ||
| import * as url from "url"; | ||
| import * as path from "path"; | ||
| import { | ||
| PrettierFileInfoOptions, | ||
| PrettierFileInfoResult, | ||
| PrettierOptions, | ||
| PrettierSupportLanguage, | ||
| } from "./types"; | ||
|
|
||
| const worker = new Worker( | ||
| url.pathToFileURL(path.join(__dirname, "/worker/prettier-instance-worker.js")) | ||
| ); | ||
|
|
||
| function findAndRemove<T>(array: Array<T>, predicate: (element: T) => boolean) { | ||
| const index = array.findIndex(predicate); | ||
| if (index === -1) { | ||
| return null; | ||
| } else { | ||
| return array.splice(index, 1)[0]; | ||
| } | ||
| } | ||
|
|
||
| export class PrettierWorkerInstance { | ||
| private importResolver: { | ||
| resolve: (version: string) => void; | ||
| reject: (version: string) => void; | ||
| } | null = null; | ||
|
|
||
| private callMethodResolvers: { | ||
| id: number; | ||
| resolve: (value: unknown) => void; | ||
| reject: (value: unknown) => void; | ||
| }[] = []; | ||
|
There was a problem hiding this comment. Maybe we can use to |
||
|
|
||
| private currentCallMethodId = 0; | ||
|
|
||
| public version: string | null = null; | ||
|
|
||
| constructor(private modulePath: string) { | ||
| worker.on("message", ({ type, payload }) => { | ||
| switch (type) { | ||
| case "import": { | ||
| this.importResolver?.resolve(payload.version); | ||
| this.version = payload.version; | ||
| break; | ||
| } | ||
| case "callMethod": { | ||
| const resolver = findAndRemove(this.callMethodResolvers, ({ id }) => { | ||
| return id === payload.id; | ||
| }); | ||
| if (resolver) { | ||
| if (payload.isError) { | ||
| resolver.reject(payload.result); | ||
| } else { | ||
| resolver.resolve(payload.result); | ||
| } | ||
| } | ||
| break; | ||
| } | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| public async import(): Promise</* version of imported prettier */ string> { | ||
| const promise = new Promise<string>((resolve, reject) => { | ||
| this.importResolver = { resolve, reject }; | ||
| }); | ||
| worker.postMessage({ | ||
| type: "import", | ||
| payload: { modulePath: this.modulePath }, | ||
| }); | ||
| return promise; | ||
| } | ||
|
|
||
| public async format( | ||
| source: string, | ||
| options?: PrettierOptions | ||
| ): Promise<string> { | ||
| const result = this.callMethod("format", [source, options]); | ||
| return result; | ||
| } | ||
|
|
||
| public async getSupportInfo(): Promise<{ | ||
| languages: PrettierSupportLanguage[]; | ||
| }> { | ||
| const result = await this.callMethod("getSupportInfo", []); | ||
|
There was a problem hiding this comment. Why these two methods, one |
||
| return result; | ||
| } | ||
|
|
||
| public async clearConfigCache(): Promise<void> { | ||
| await this.callMethod("clearConfigCache", []); | ||
| } | ||
|
|
||
| public async getFileInfo( | ||
| filePath: string, | ||
| fileInfoOptions?: PrettierFileInfoOptions | ||
| ): Promise<PrettierFileInfoResult> { | ||
| const result = await this.callMethod("getFileInfo", [ | ||
| filePath, | ||
| fileInfoOptions, | ||
| ]); | ||
| return result; | ||
| } | ||
|
|
||
| private callMethod(methodName: string, methodArgs: unknown[]): Promise<any> { | ||
| const callMethodId = this.currentCallMethodId++; | ||
| const promise = new Promise((resolve, reject) => { | ||
| this.callMethodResolvers.push({ id: callMethodId, resolve, reject }); | ||
| }); | ||
| worker.postMessage({ | ||
| type: "callMethod", | ||
| payload: { | ||
| id: callMethodId, | ||
| modulePath: this.modulePath, | ||
| methodName, | ||
| methodArgs, | ||
| }, | ||
| }); | ||
| return promise; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't really access all properties of the module. I'd do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really need to access any properties other than version, so I think we can leave it as is.