-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New passthrough(pt) property implementation for Button Components #4360
Comments
Button commit: 5b41227 |
It looks like this change introduced a bug. If you look at Card.spec.js it now is expecting this. <Button label="Cancel" icon="pi pi-times" className="p-button-secondary ml-2" /> See how the <button
aria-label="Cancel"
class="p-button p-component p-button-secondary ml-2 p-button-secondary ml-2"
> |
What do you think about changing or editing the test file (spec).js? It seems more preferable to me. |
we can update the test output but what I thought was strange was the classes are duplicated if this happens then it feels like the Button code is doing something new that is causing this. |
You're right, we should avoid duplicates. Let me check. |
Refactor #4360 - For SpeedDial Wireframe
The text was updated successfully, but these errors were encountered: