Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New passthrough(pt) property implementation for Button Components #4360

Closed
3 tasks done
ulasturann opened this issue May 8, 2023 · 5 comments · Fixed by #4365, #4372 or #4373
Closed
3 tasks done

New passthrough(pt) property implementation for Button Components #4360

ulasturann opened this issue May 8, 2023 · 5 comments · Fixed by #4365, #4372 or #4373
Assignees
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@ulasturann
Copy link
Contributor

ulasturann commented May 8, 2023

  • Button
  • SpeedDial
  • SplitButton
@ulasturann ulasturann added Type: New Feature Issue contains a new feature or new component request Core Team Issue or pull request has been *opened* by a member of Core Team labels May 8, 2023
@ulasturann ulasturann added this to the 9.4.0 milestone May 8, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 8, 2023
@habubey
Copy link
Contributor

habubey commented May 9, 2023

Button commit: 5b41227

melloware pushed a commit to ecstrema/primereact that referenced this issue May 9, 2023
@melloware
Copy link
Member

It looks like this change introduced a bug. If you look at Card.spec.js it now is expecting this.

<Button label="Cancel" icon="pi pi-times" className="p-button-secondary ml-2" />

See how the className is duplicated in the output?

<button
            aria-label="Cancel"
            class="p-button p-component p-button-secondary ml-2 p-button-secondary ml-2"
          >

@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 9, 2023
@habubey
Copy link
Contributor

habubey commented May 9, 2023

What do you think about changing or editing the test file (spec).js? It seems more preferable to me.

@melloware
Copy link
Member

melloware commented May 9, 2023

we can update the test output but what I thought was strange was the classes are duplicated class="p-button p-component p-button-secondary ml-2 p-button-secondary ml-2" which does this happen in the real browser with Button now?

if this happens then it feels like the Button code is doing something new that is causing this.

@habubey
Copy link
Contributor

habubey commented May 9, 2023

You're right, we should avoid duplicates. Let me check.

melloware added a commit to melloware/primereact that referenced this issue May 9, 2023
@melloware melloware reopened this May 9, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 9, 2023
melloware added a commit to melloware/primereact that referenced this issue May 10, 2023
melloware added a commit to melloware/primereact that referenced this issue May 10, 2023
melloware added a commit to melloware/primereact that referenced this issue May 10, 2023
habubey added a commit that referenced this issue May 10, 2023
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 10, 2023
@melloware melloware reopened this May 10, 2023
habubey added a commit that referenced this issue May 11, 2023
ulasturann added a commit that referenced this issue May 11, 2023
ulasturann added a commit that referenced this issue May 16, 2023
Refactor #4360 - For SpeedDial Wireframe
habubey added a commit that referenced this issue Jun 2, 2023
habubey added a commit that referenced this issue Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: New Feature Issue contains a new feature or new component request
Projects
None yet
4 participants