Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password > Icon and Input render order > tabIndex issue #6593

Closed
cbaum86 opened this issue May 8, 2024 · 1 comment · Fixed by #6598, leoo1992/GeradorQRCode#40, mtech-31-quemistry/quemistry_client_web#3 or leoo1992/GeradorQRCode#57 · May be fixed by nhattpn/BTL_LTNC#56
Assignees
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone

Comments

@cbaum86
Copy link

cbaum86 commented May 8, 2024

Describe the bug

Previously (<= v10.6.3) if using the Password component with the toggleMask prop when the component was rendered in the DOM, tabbing through a form the input component would be tabbed to first and then the toggleMask secondary.
However, now the Password component renders differently and the toggleMask is tabbed to first, followed by the input secondary.
This feels like bad user experience.

Reproducer

https://react-cmjtr2.stackblitz.io

PrimeReact version

10.6.5

React version

18.x

Language

ES6

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Click in the html doc
  2. Press the keyboard 'tab' key
  3. ToggleMask element is focused
  4. Press the keyboard 'tab' key again
  5. The password input is focused

Expected behavior

  1. Click in the html doc
  2. Press the keyboard 'tab' key
  3. Password input is focused
  4. Press the keyboard 'tab' key again
  5. ToggleMask element is focused

Expected behaviour can be seen by changing the primereact library version to 10.6.3 or lower.

@cbaum86 cbaum86 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 8, 2024
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 8, 2024
@melloware
Copy link
Member

Agreed it should work the same as far as tabbing goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment