Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #6680, Tooltip: Escape key not dismissing tooltip (WCAG 2.1 1.4.13) #6687

Merged
merged 5 commits into from
May 27, 2024
Merged

fix: #6680, Tooltip: Escape key not dismissing tooltip (WCAG 2.1 1.4.13) #6687

merged 5 commits into from
May 27, 2024

Conversation

akshayaqburst
Copy link
Contributor

Defect Fixes

fix: #6680, Tooltip: Escape key not dismissing tooltip (WCAG 2.1 1.4.13)

@vercel Vercel
Copy link

vercel bot commented May 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 8:21pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 8:21pm

@akshayaqburst
Copy link
Contributor Author

Anyway, we have to specify closeOnEscape in the tooltipOptions prop, which is already specified in the documentation.

            <InputText value={value} onChange={(e) => setValue(e.target.value)}  tooltip="tooltip content" tooltipOptions={{closeOnEscape: true}} />

melloware
melloware requested changes May 27, 2024
View reviewed changes
components/lib/hooks/useGlobalOnEscapeKey.js Outdated Show resolved Hide resolved
components/lib/tooltip/Tooltip.js Show resolved Hide resolved
@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label May 27, 2024
@melloware melloware merged commit f5237b1 into primefaces:master May 27, 2024
4 checks passed
@nhattpn nhattpn mentioned this pull request Jul 25, 2024
Open
@leoo1992 leoo1992 mentioned this pull request Jul 25, 2024
Merged
@leoo1992 leoo1992 mentioned this pull request Aug 19, 2024
Merged
@hiterharris hiterharris mentioned this pull request Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip: Escape key not dismissing tooltip (WCAG 2.1 1.4.13)
2 participants
@akshayaqburst @melloware