Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6922: fix input passthrough TS #6938

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

melloware
Copy link
Member

Fix #6922: fix input passthrough TS

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Jul 27, 2024
Copy link

vercel bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jul 27, 2024 5:11pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jul 27, 2024 5:11pm

@melloware melloware merged commit 0587fda into primefaces:master Jul 27, 2024
6 checks passed
@melloware melloware deleted the PR6922 branch July 27, 2024 17:11
@ivanpajon
Copy link
Contributor

ivanpajon commented Jul 30, 2024

This breaks #6676

Pass through options of Calendar component should be of type CalendarPassThroughMethodOptions. Problem here is that example of theming in documentation is outdated (I think). Documentation says to do:
image

But in order to access showIcon and all Calendar props you need to do:
image

(This also applies to Cascade and InputOtp components)

@melloware
Copy link
Member Author

@ivanpajon please submit a PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete: Passthrough to input not working
2 participants