Add test

primer · Sep 20, 2024 · d5b5ec9 · d5b5ec9
1 parent 6ad6b65
commit d5b5ec9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/react/src/Overlay/Overlay.test.tsx b/packages/react/src/Overlay/Overlay.test.tsx
@@ -303,4 +303,13 @@ describe('Overlay', () => {
     expect(queryByRole('dialog')).not.toBeInTheDocument()
     expect(queryByRole('none')).toBeInTheDocument()
   })
+
+  it('should add `aria-modal` if `role="dialog"` is present', async () => {
+    const user = userEvent.setup()
+    const {getByText, queryByRole} = render(<TestComponent role="dialog" />)
+
+    await user.click(getByText('open overlay'))
+
+    expect(queryByRole('dialog')).toHaveAttribute('aria-modal')
+  })
 })
diff --git a/packages/react/src/Overlay/Overlay.tsx b/packages/react/src/Overlay/Overlay.tsx
@@ -207,7 +207,7 @@ const Overlay = React.forwardRef<HTMLDivElement, OwnOverlayProps>(
     const dialog = role && role !== 'dialog' ? true : false
 
     useFocusTrap({
-      containerRef: overlayRef, // only if `role="dialog"`, `aria-modal="true"` is true
+      containerRef: overlayRef,
       disabled: !focusTrap || dialog,
     })