Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The popover for UnderlineNav is clipped in mobile viewports #4059

Closed
joshblack opened this issue Dec 14, 2023 · 4 comments · Fixed by #4234
Closed

The popover for UnderlineNav is clipped in mobile viewports #4059

joshblack opened this issue Dec 14, 2023 · 4 comments · Fixed by #4234
Assignees
Labels

Comments

@joshblack
Copy link
Member

Description

The popover for UnderlineNav is clipped in mobile viewports

Steps to reproduce

I noticed this when using the latest repo beta opt-in 👀

  1. Visit a repo: https://github.com/primer/react
  2. Scroll down to the UnderlineNav usage for the README, Code of Conduct, etc
  3. Narrow the viewport` to a mobile viewport size (so that the More button is visible)
  4. Activate the button to trigger the popover
  5. Observe that the popover is clipped by the viewport

Version

v36.x

Browser

Chrome

@lesliecdubs
Copy link
Member

@joshblack can you share a screenshot? We tried replicating by enabling the "New organization repositories view" feature preview and then testing mobile size using the reproduction steps, but couldn't see the nav getting clipped 👀

@joshblack
Copy link
Member Author

@lesliecdubs definitely! Here's one:

Image of popover clipped for underline nav

Basically the underline nav needs to have all items except the first one truncated to get it to happen.

Copy link
Contributor

Uh oh! @joshblack, the image you shared is missing helpful alt text. Check #4059 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@broccolinisoup
Copy link
Member

Thanks @joshblack! Yeah this is still in the supported viewport range and we need to fix it. I guess we could leverage anchor positioning here, I'll look into it 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment