Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote PageHeader to Beta 🎉 #4725

Merged
merged 8 commits into from
Jul 19, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nice-forks-joke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

PageHeader: Promote the component to Beta status and now it is available to import from "@primer/react"
broccolinisoup marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion packages/react/src/PageHeader/PageHeader.dev.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {GitBranchIcon, PencilIcon, SidebarExpandIcon} from '@primer/octicons-rea
import {PageHeader} from './PageHeader'

const meta: Meta<typeof PageHeader> = {
title: 'Drafts/Components/PageHeader/DevOnly',
title: 'Components/PageHeader/DevOnly',
parameters: {
layout: 'fullscreen',
controls: {expanded: true},
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/PageHeader/PageHeader.docs.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"id": "drafts_page_header",
"name": "PageHeader",
"status": "draft",
"status": "alpha",
broccolinisoup marked this conversation as resolved.
Show resolved Hide resolved
"a11yReviewed": true,
"stories": [],
"importPath": "@primer/react/experimental",
"importPath": "@primer/react",
"props": [
{
"name": "aria-label",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import {ActionMenu} from '../ActionMenu'
import {ActionList} from '../ActionList'

const meta: Meta = {
title: 'Drafts/Components/PageHeader/Examples',
title: 'Components/PageHeader/Examples',
parameters: {
layout: 'fullscreen',
controls: {expanded: true},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {PageHeader} from './PageHeader'
import {Hidden} from '../Hidden'

const meta: Meta = {
title: 'Drafts/Components/PageHeader/Features',
title: 'Components/PageHeader/Features',
parameters: {
layout: 'fullscreen',
controls: {expanded: true},
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/PageHeader/PageHeader.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {PageHeader} from './PageHeader'
import Hidden from '../Hidden'

const meta: Meta<typeof PageHeader> = {
title: 'Drafts/Components/PageHeader',
title: 'Components/PageHeader',
parameters: {
layout: 'fullscreen',
controls: {expanded: true},
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/PageHeader/PageHeader.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, {useEffect} from 'react'
import {Box} from '..'
import Box from '../Box'
import type {ResponsiveValue} from '../hooks/useResponsiveValue'
import {useResponsiveValue} from '../hooks/useResponsiveValue'
import type {SxProp, BetterSystemStyleObject, CSSCustomProperties} from '../sx'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ exports[`@primer/react should not update exports without a semver change 1`] = `
"Overlay",
"type OverlayProps",
"Pagehead",
"PageHeader",
"type PageHeaderProps",
"type PageheadProps",
"PageLayout",
"type PageLayoutContentProps",
Expand Down
3 changes: 3 additions & 0 deletions packages/react/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ export type {UnderlineNavProps, UnderlineNavItemProps} from './UnderlineNav'
export {ActionBar} from './ActionBar'
export type {ActionBarProps} from './ActionBar'

export {PageHeader} from './PageHeader'
export type {PageHeaderProps} from './PageHeader'

// eslint-disable-next-line no-restricted-imports
export {SSRProvider, useSSRSafeId} from './utils/ssr'
export {default as sx, merge} from './sx'
Expand Down
40 changes: 20 additions & 20 deletions script/generate-e2e-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -835,83 +835,83 @@ const components = new Map([
{
stories: [
{
id: 'drafts-components-pageheader-examples--files-page',
id: 'components-pageheader-examples--files-page',
name: 'Files Page',
},
{
id: 'drafts-components-pageheader-examples--files-page-on-narrow-viewport',
id: 'components-pageheader-examples--files-page-on-narrow-viewport',
name: 'Files Page on Narrow Viewport',
},
{
id: 'drafts-components-pageheader-examples--pull-request-page',
id: 'components-pageheader-examples--pull-request-page',
name: 'Pull Request Page',
},
{
id: 'drafts-components-pageheader-examples--pull-request-page-on-narrow-viewport',
id: 'components-pageheader-examples--pull-request-page-on-narrow-viewport',
name: 'Pull Request Page on Narrow Viewport',
},
{
id: 'drafts-components-pageheader-examples--webhooks',
id: 'components-pageheader-examples--webhooks',
name: 'Webhooks',
},
{
id: 'drafts-components-pageheader-examples--webhooks-on-narrow-viewport',
id: 'components-pageheader-examples--webhooks-on-narrow-viewport',
name: 'Webhooks on Narrow Viewport',
},
{
id: 'drafts-components-pageheader-examples--with-page-layout',
id: 'components-pageheader-examples--with-page-layout',
name: 'With Page Layout',
},
{
id: 'drafts-components-pageheader-features--has-large-title',
id: 'components-pageheader-features--has-large-title',
name: 'Has Large Title',
},
{
id: 'drafts-components-pageheader-features--has-title-only',
id: 'components-pageheader-features--has-title-only',
name: 'Has Title Only',
},
{
id: 'drafts-components-pageheader-features--with-actions',
id: 'components-pageheader-features--with-actions',
name: 'With Actions',
},
{
id: 'drafts-components-pageheader-features--with-actions-that-have-responsive-content',
id: 'components-pageheader-features--with-actions-that-have-responsive-content',
name: 'With Actions that have Responsive Content',
},
{
id: 'drafts-components-pageheader-features--with-context-bar-and-actions-of-context-area',
id: 'components-pageheader-features--with-context-bar-and-actions-of-context-area',
name: 'With Context Bar and Actions of Context Area',
},
{
id: 'drafts-components-pageheader-features--with-custom-navigation',
id: 'components-pageheader-features--with-custom-navigation',
name: 'With Custom Navigation',
},
{
id: 'drafts-components-pageheader-features--with-description-slot',
id: 'components-pageheader-features--with-description-slot',
name: 'With Description Slot',
},
{
id: 'drafts-components-pageheader-features--with-leading-and-trailing-actions',
id: 'components-pageheader-features--with-leading-and-trailing-actions',
name: 'With Leading and Trailing Actions',
},
{
id: 'drafts-components-pageheader-features--with-leading-and-trailing-visuals',
id: 'components-pageheader-features--with-leading-and-trailing-visuals',
name: 'With Leading and Trailing Visuals',
},
{
id: 'drafts-components-pageheader-features--with-leading-visual-hidden-on-regular-viewport',
id: 'components-pageheader-features--with-leading-visual-hidden-on-regular-viewport',
name: 'With Leading Visual Hidden on Regular Viewport',
},
{
id: 'drafts-components-pageheader-features--with-navigation-slot',
id: 'components-pageheader-features--with-navigation-slot',
name: 'With Navigation Slot',
},
{
id: 'drafts-components-pageheader-features--with-parent-link-and-actions-of-context-area',
id: 'components-pageheader-features--with-parent-link-and-actions-of-context-area',
name: 'With Parent Link and Actions of Context Area',
},
{
id: 'drafts-components-pageheader-devonly--large-variant-with-multiline-title',
id: 'components-pageheader-devonly--large-variant-with-multiline-title',
name: 'Large Variant with Multiline Title',
},
],
Expand Down
Loading