-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): add theming example #4948
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍🏻
> | ||
<body> | ||
<StyledComponentsRegistry> | ||
<ThemeProvider colorMode={colorMode}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we note that <ThemeProvider
here is temporary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No preference on my end, happy to add it if it would be helpful 👍
data-color-mode={colorMode} | ||
data-light-theme="light" | ||
data-dark-theme="dark" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the idea that this could one day be a helper function
data-color-mode={colorMode} | |
data-light-theme="light" | |
data-dark-theme="dark" | |
{...colorThemeAttributes(colorMode)} |
Add a theming example to our
examples
directory. This example is to help us test out changes toThemeProvider
as we move over to CSS Modules.Changelog
New
examples/theming
example with Next.js App RouterChanged
Removed
Rollout strategy
This is a local example that will not impact the public API of a Primer package