Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Banner): update alignment of actions when Banner is dismissible #4954

Merged
merged 7 commits into from
Sep 13, 2024
Merged

fix(Banner): update alignment of actions when Banner is dismissible #4954

merged 7 commits into from
Sep 13, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 12, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/3957

Changelog

New

Changed

  • Update styling for Banner to work when the banner is dismissible, has a hidden title, and actions

Removed

Rollout strategy

  • Patch release

Testing & Reviewing

  • Verify that the changes here address the issue above
  • Verify that no regressions occur in layout 😅

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4b3a582

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 12, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4954 September 12, 2024 16:29 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.16 KB (0%)
packages/react/dist/browser.umd.js 97.4 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4954 September 12, 2024 16:37 Inactive
@joshblack joshblack marked this pull request as ready for review September 12, 2024 16:57
@joshblack joshblack requested review from a team as code owners September 12, 2024 16:57
@joshblack
Copy link
Member Author

Note: just realized with the snapshots that the buttons are not in the right order, looking at this now 👀

@github-actions github-actions bot temporarily deployed to storybook-preview-4954 September 12, 2024 17:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4954 September 12, 2024 17:27 Inactive
@joshblack @siddharthkp
Update .changeset/spicy-eggs-melt.md
4b3a582 
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
@joshblack joshblack added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit af7f589 Sep 13, 2024
32 checks passed
@joshblack joshblack deleted the fix/update-banner-actions-when-hidden-title branch September 13, 2024 15:52
@primer primer bot mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

@langermank langermank langermank approved these changes

@lukasoppermann lukasoppermann Awaiting requested review from lukasoppermann

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @siddharthkp @langermank