-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add experimental IssueLabel component #4960
base: main
Are you sure you want to change the base?
Conversation
* adding color algo for hex colors * fix tests * update snap name * test(vrt): update snapshots --------- Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com> Co-authored-by: langermank <langermank@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 5d9a13a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code overall looks good to me! And it is great to have accessible colours on the labels 🎉 Thanks so much for your work on this 🙏🏻
Just a few points/questions:
- Is
IssueLabel
going to be a replacement for the currentLabel
component? - When I tried setting hex colours on the playground story, sometimes it throws an error with
Failed to parse color: "#0f0f0"
(as I shared below on the screenshot)
Pulling work from #4535 to add support for an experimental
IssueLabel
componentChangelog
New
Changed
Removed
Rollout strategy